popover: Remove useless if case
authorTimm Bäder <mail@baedert.org>
Sat, 3 Jun 2017 12:38:56 +0000 (14:38 +0200)
committerMatthias Clasen <mclasen@redhat.com>
Thu, 20 Jul 2017 01:27:13 +0000 (21:27 -0400)
rect is not nullable, so stop checking if it is NULL and instead add a
g_return_val_if_fail guard.

gtk/gtkpopover.c

index 2f866c9d0b7631492be2edc0f424430b7b755fd7..84ce4e5b66c89b076cb5d3ebb1154b1e1f724dca 100644 (file)
@@ -2121,16 +2121,14 @@ gtk_popover_get_pointing_to (GtkPopover   *popover,
   GtkPopoverPrivate *priv = gtk_popover_get_instance_private (popover);
 
   g_return_val_if_fail (GTK_IS_POPOVER (popover), FALSE);
+  g_return_val_if_fail (rect != NULL, FALSE);
 
-  if (rect)
+  if (priv->has_pointing_to)
+    *rect = priv->pointing_to;
+  else if (priv->widget)
     {
-      if (priv->has_pointing_to)
-        *rect = priv->pointing_to;
-      else if (priv->widget)
-        {
-          gtk_widget_get_allocation (priv->widget, rect);
-          rect->x = rect->y = 0;
-        }
+      gtk_widget_get_allocation (priv->widget, rect);
+      rect->x = rect->y = 0;
     }
 
   return priv->has_pointing_to;